Fix scheme detection for external links #11942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poire-z
reviewed
May 31, 2024
| local scheme = link_url:match("^(%w+)://") | ||
| local is_handled_external_link = scheme and util.arrayContains(self.handledSchemes, scheme) | ||
| local scheme = link_url:match("^(%w[%w+%-.]*):") | ||
| local is_handled_external_link = scheme and util.arrayContains(self.handledSchemes, scheme:lower()) |
There was a problem hiding this comment.
I'm a bit too late to comment on the first PR, so doing it on the second :)
"handled" sounds to me like "done being processed".
"supported" would read less strange, like "we can process it, we'll do that later".
There was a problem hiding this comment.
I suppose I said something similar in #11889 (comment)
But handled can make sense as well because passing it off to the system doesn't include much supporting for example. I haven't double checked what all the specific behaviors are right now though.
There was a problem hiding this comment.
Yes, "supported" is good. Done.
Following RFC 3986.
poire-z
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following RFC 3986.
The previous code failed on URIs like "about:foo", and on links containing upper case in the scheme.
This change is