[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations: Bookmark list improvement #11825

Merged
merged 5 commits into from
May 16, 2024
Merged

Annotations: Bookmark list improvement #11825

merged 5 commits into from
May 16, 2024

Conversation

hius07
Copy link
Member
@hius07 hius07 commented May 15, 2024

Mostly internal optimization, but also some UI changes:
(1) Good bookmark list header showing filtering status
(2) Bookmark details with arrows for next/previous bookmark jump
(3) Bookmark details window is not closed after editing note/text, to review the changes

1

2

3

4

5


This change is Reviewable

Copy link
Contributor
@poire-z poire-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with the features.
A bit too much to review, so trusting you on all this.

@Frenzie Frenzie added this to the 2024.05 milestone May 16, 2024
Copy link
Member
@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, please squash & merge if you feel confident. 👍

@hius07 hius07 merged commit 6b192c3 into koreader:master May 16, 2024
3 checks passed
@hius07 hius07 deleted the bm-list branch May 16, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants