-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SortWidget: sort alphabetically #11705
Conversation
Thanks for adding this. Had a quick test and what stood out was that it is case sensitive; a-z comes after A-Z. Should probably be case insensitive? |
I think that's @NiLuJe's cue. xD (See https://en.wikipedia.org/wiki/Natural_sort_order for some background.) |
:D IIRC, we do have a natsort-ish variant in the FM sorting hat, and while that usually didn't really matter in SortWidget, the one example being shown here (e.g., Collections) might be the one where it... does ;). |
Exactly, let's reuse it: koreader/frontend/ui/widget/sortwidget.lua Lines 528 to 529 in cae7e8b
|
Wouldn’t it be better to have just two choices (a to z and natural sort) and a reverse sorting option? It would be more in-line with the way it works on file browser. |
(As well as file managers in general.) |
In fact, why not just have the natural sorting one? (Same for the other file manager/browser) |
Performance. The dumb one is significantly faster. |
It's a one-time operation, not a long-lasting setting like in FM. |
This change is