[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kindle Scribe: fix gyro device detection (again) #11696

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

mergen3107
Copy link
Contributor
@mergen3107 mergen3107 commented Apr 19, 2024

Fixes #11691

It turned out there might another type of accelerometer declaration.

I didn’t quite feel creating another edge case, so instead I shortened current searching keyword “accel” to “acc”.

@NiLuJe @Frenzie
Please wait before merge: I want to test this on my own Scribe first.

Also, I don’t know what to do if there are multiple “acc” matches. (Is this even possible?)


This change is Reviewable

@klpinor
Copy link
klpinor commented Apr 19, 2024

@mergen3107

On my Kindle Scribe's device.lua, there are multiple "accel" occurrences (I think there were 8 or 9?), but most "accel" occurrences were in the comments, and only one "accel" occurrence was not commented out (i.e., no leading "--" at front of line having "accel"). So when I did the search and replace you requested, I only replaced the 1x "accel" occurrence (replaced it with "acc") that was not commented out. Hope this helps!

@mergen3107
Copy link
Contributor Author

Yes, you did right - that means you replaced only the one in Kindle Scribe init part. There might be other in Kindle Oasis parts, but you wouldn't have seen your gyro if you changed that.

@Frenzie Frenzie added the Kindle label Apr 19, 2024
@mergen3107
Copy link
Contributor Author

@NiLuJe @Frenzie
Tests are successful.
Ready to merge!

@NiLuJe
Copy link
Member
NiLuJe commented Apr 20, 2024

For science, what's the actual name of the accelerometer on those devices?

@Frenzie
Copy link
Member
Frenzie commented Apr 20, 2024

I think it said bma4xy_acc.

@Frenzie Frenzie added this to the 2024.04 milestone Apr 20, 2024
@Frenzie Frenzie merged commit caea0e8 into koreader:master Apr 20, 2024
2 of 3 checks passed
@mergen3107
Copy link
Contributor Author

Thanks!

@mergen3107 mergen3107 deleted the Kindle-Scribe-fix-gyro-(again) branch May 8, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KOReader on jb Kindle Scribe - Not opening either through KUAL or through KOL Booklet
4 participants