View Customization: Enable extra integer argument in view constructors etc. #8202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Trott <crtrott@sandia.gov>
This tests both constructor and shmem_size function. Signed-off-by: Christian Trott <crtrott@sandia.gov>
626c322 to
142fbe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables passing extra integer arguments to the respective places in Kokkos View as the current Sacado partial specialization allows. We likely want to deprecate these code paths in a subsequent PR. For
shmem_sizeandrequired_allocation_sizewe need to invent new interfaces however to do that (hence subsequent PR)Specifically for construction for Sacado the following is equivalent now: