GCC minimum version for cxx 20 #8130
Conversation
Proposing to raise the minimum version of gcc to avoid running into the issue of LWG-3446: https://cplusplus.github.io/LWG/issue3446 This issue is causing failures in Trilinos but not in Kokkos yet. Note that the gcc versions currently affected by LWG-3446 are: - gcc < 10.4.0 - gcc < 11.1.0 - clang < 14 Please let me know if the proposed change of minimum gcc raises issues with any important customer and/or platform. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
|
Is it gcc < 10.40 or gcc < 11.1.0? I guess you meant a different compiler for the second version number? |
|
No, gcc keeps patching multiple major versions at the same time. Based on the timeline of their releases I suspect they fixed the issue in gcc/12.0.0 and then back-ported it gcc/10.4.0 and gcc/11.1.0 which means that gcc/11.0.0 has the bug while 10.4.0 and 10.5.0 do not... |
Should we then try going to gcc-12? We should also consider what the latest distros ship. Ubuntu 24.04 seems to ship gcc-13.2. |
|
I think 11.1 is reasonable and avoids logic on our side. As long as no one needs gcc 10 ... |
| @@ -173,7 +173,7 @@ else() | |||
| set(KOKKOS_CLANG_CPU_MINIMUM 14.0.0) | |||
| set(KOKKOS_CLANG_CUDA_MINIMUM 14.0.0) | |||
| set(KOKKOS_CLANG_OPENMPTARGET_MINIMUM 15.0.0) | |||
| set(KOKKOS_GCC_MINIMUM 10.1.0) | |||
| set(KOKKOS_GCC_MINIMUM 10.4.0) | |||
There was a problem hiding this comment.
| set(KOKKOS_GCC_MINIMUM 10.4.0) | |
| set(KOKKOS_GCC_MINIMUM 11.1.0) |
|
I looked at release dates. The GCC 10.4 is fairly new June 2022. 11.1 is April 2021, 10.1 is May 2020, 12.1 is May 22. I feel slightly uncomfortable raising the date all the way to 22. Let me confer with folks on our side regarding minimum version. Note that Kokkos itself would be fine with the older GCC. |
Proposing to raise the minimum version of gcc to avoid running into the issue of LWG-3446: https://cplusplus.github.io/LWG/issue3446 This issue is causing failures in Trilinos but not in Kokkos yet. Note that the gcc versions currently affected by LWG-3446 are:
Please let me know if the proposed change of minimum gcc raises issues with any important customer and/or platform.