8000 Fix TypeError when a connection error occurs with Streams by mmollick · Pull Request #6197 · knex/knex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix TypeError when a connection error occurs with Streams #6197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix TypeError when a connection error occurs with Streams #6197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/client.js
View file
730D Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,11 @@ class Client extends EventEmitter {
// Releases a connection back to the connection pool,
// returning a promise resolved when the connection is released.
releaseConnection(connection) {
if (!connection) {
debug('no connection to release');
return Promise.resolve();
}

debug('releasing connection to pool: %s', connection.__knexUid);
const didRelease = this.pool.release(connection);

Expand Down
0