8000 fix: do not warn for missing filename if connection is a function by innerdvations · Pull Request #6136 · knex/knex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: do not warn for missing filename if connection is a function #6136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not warn for missing filename if connection is a function #6136

wants to merge 1 commit into from
+1 −1

Conversation

innerdvations
Copy link
@innerdvations innerdvations commented Oct 4, 2024 •
edited
Loading

If a connection function is used for sqlite3, it warns that the filename is missing even though once the connection function resolves to an object, the filename actually exists.

This PR just assumes if you're using a connection function you know what you're doing. But we could go further and warn in acquireRawConnection, but it seems like that could result in multiple warnings in some cases. Is there a better place this warning could go?

@innerdvations innerdvations mentioned this pull request Oct 4, 2024
Merged
@innerdvations innerdvations changed the title fix: do not warn for sqlite3 filename warning if connection is a function fix: do not warn for missing filename if connection is a function Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@innerdvations
0