8000 Remove all x86 python versions and py 3.6 in pipy-win workflow by DivingDuck · Pull Request #1353 · kliment/Printrun · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove all x86 python versions and py 3.6 in pipy-win workflow #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Remove all x86 python versions and py 3.6 in pipy-win workflow #1353

wants to merge 0 commits into from

Conversation

DivingDuck
Copy link
Collaborator

Remove of Python 3.6 and all x86 python versions from windows workflow pipy-win.yml. Both are not supported by wxPython 4.2.

This should solve the workflow error of this workflow as well.
I would suggest to do this for all other os workflows too.

@DivingDuck DivingDuck requested a review from rockstorm101 May 11, 2023 08:39
@rockstorm101 rockstorm101 mentioned this pull request May 11, 2023
Merged
@rockstorm101
Copy link
Collaborator

Sorry for cross-posting, I'm bringing here this discussion since it is more appropriate.

I think we shouldn't build all those environments if we can't use them at all. wxpython 4.2 won't support any of this versions for windows. I like to minimize the use of resources (and possible errors for not used stuff). I must confess that I forgot to check this again when we build 2.0.

For macOS it looks like they are on the way to stop support for macOS 10.15: https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/

Good points. I'm happy to drop support for Python 3.6 all over then, including macOS. As you said, it makes no sense to keep it.

I'm however a bit uneasy with removing the 32-bit wheel for Windows. Even though wxPython does not provide wheels for 32-bit, there seems to be some user base still relying on 32-bit Windows (judging the activity on this thread).

Similar comments goes for macOS 10.15. Last thing I know is that there are people still using this version, so I would leave it there as long as we can.

rockstorm101 added a commit that referenced this pull request May 13, 2023
@rockstorm101
ci: Drop support for Python 3.6 and macOS 10.15
cbf6d03 
Python 3.6 is not supported by wxPython 4.2 so it doesn't make sense
for us to support it anyway. And GitHub does not provide a runner for
macOS 10.15 anymore. See #1353 for more context.
@DivingDuck DivingDuck closed this Aug 14, 2023
@DivingDuck
Copy link
Collaborator Author

Some cleanup.
I close this issue because of already partly integrated (drop python 3.6 support).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockstorm101 rockstorm101 Awaiting requested review from rockstorm101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DivingDuck @rockstorm101
0