8000 first git for statedb pruning by ethan-kr · Pull Request #1831 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

first git for statedb pruning #1831

Closed
wants to merge 7 commits into from
8000
Closed

first git for statedb pruning #1831

wants to merge 7 commits into from

Conversation

ethan-kr
Copy link
Contributor
@ethan-kr ethan-kr commented Apr 19, 2023 •
edited by yoomee1313
Loading

Proposed changes

First commit to Statedb-pruning - draft & test case debug

  • The key element is the addition of Extended Hash (ExtHash).
  • ExtHash removes hash duplication by adding an additional 6 bytes to the existing 32-byte hash.
  • In this PR, most of the changes are mainly made by applying the ExtHash structure.
  • Therefore, type conversion through two functions is the most code change.
    ToRootExtHash(Hash -> ExtHash), ToHash(ExtHash -> Hash)
  • reference document

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CLAassistant
Copy link
CLAassistant commented Apr 19, 2023 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ethan-kr
✅ jeongkyun-oh
❌ ethan

ethan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ethan-kr
Test case port to ExtHash
e93418c 
snapshot test case bug fix & downloader debug
@ethan-kr ethan-kr force-pushed the statedb-pruning branch from 082ffa0 to e218d90 Compare May 3, 2023 18:09
@ethan-kr ethan-kr marked this pull request as draft May 15, 2023 04:55
@aidan-kwon
Copy link
Member

Close this because it is implemented through other separated PRs

@aidan-kwon aidan-kwon closed this Jul 18, 2023
@swapscanner-ryan
Copy link

@aidan-kwon could you share the PR # here?

@aidan-kwon
Copy link
Member

@swapscanner-ryan Sure!
Live state pruning was proposed in klaytn/kips#112 (still in review) and implemented in #1852 #1854 #1859 #1871 #1899

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blukat29 blukat29 Awaiting requested review from blukat29 blukat29 is a code owner

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon aidan-kwon is a code owner

@kjhman21 kjhman21 Awaiting requested review from kjhman21

@yoomee1313 yoomee1313 Awaiting requested review from yoomee1313 yoomee1313 is a code owner

@jeongkyun-oh jeongkyun-oh Awaiting requested review from jeongkyun-oh jeongkyun-oh is a code owner

@hyunsooda hyunsooda Awaiting requested review from hyunsooda hyunsooda is a code owner

@2dvorak 2dvorak Awaiting requested review from 2dvorak 2dvorak is a code owner

@ian0371 ian0371 Awaiting requested review from ian0371 ian0371 is a code owner

@jiseongnoh jiseongnoh Awaiting requested review from jiseongnoh

@kjeom kjeom Awaiting requested review from kjeom kjeom is a code owner

@henry-will henry-will Awaiting requested review from henry-will

@nohkwak nohkwak Awaiting requested review from nohkwak

@0xxlegolas 0xxlegolas Awaiting requested review from 0xxlegolas

@hyeonLewis hyeonLewis Awaiting requested review from hyeonLewis hyeonLewis will be requested when the pull request is marked ready for review hyeonLewis is a code owner

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736 JayChoi1736 will be requested when the pull request is marked ready for review JayChoi1736 is a code owner

Assignees

@ethan-kr ethan-kr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ethan-kr @CLAassistant @aidan-kwon @swapscanner-ryan @jeongkyun-oh
0