8000 [drools-lsp-52] Update grammars to the latest by tkobayas · Pull Request #54 · kiegroup/drools-lsp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[drools-lsp-52] Update grammars to the latest #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

tkobayas
Copy link
Collaborator
@tkobayas tkobayas commented Apr 15, 2025

  • Taken the latest antler4 grammar files from drools repo
    • At the moment, we don't have a public drools version which contains the new parser, so I copied the grammar files instead of having a dependency to drools-drl-parser. When drools 10.1.0 is released, we will be able add the dependency. Probably we will revisit if we want to use the dependency or keep the grammar files because we may want to customize the grammar files to support requirements from LSP clients (DRL Editor).
  • Removed Visitor class and other support classes, because we need only grammar files for LSP at the moment.
  • Removed parser/visitor tests because they are done in the drools repo. Just keep a smoke test and a util test.
  • Updated JDK from 11 to 17
  • Updated Developer_Notes

- Taken grammar files from drools repo
- Removed parser/visitor tests
- Updated JDK from 11 to 17
@tkobayas
Copy link
Collaborator Author

Hmm, test on mac is unstable?

@tkobayas tkobayas marked this pull request as draft April 15, 2025 09:12
@tkobayas tkobayas force-pushed the drools-lsp-52-update-grammar-2 branch from ccb65f4 to a971e65 Compare April 16, 2025 01:16
@tkobayas tkobayas marked this pull request as ready for review April 16, 2025 01:17
@tkobayas
Copy link
Collaborator Author

@mariofusco @gitgabrio Please review, thanks!

@tkobayas tkobayas merged commit eb824b7 into kiegroup:main Apr 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0