[MBL-2303] Subcategory support for search #2403
Merged
+113
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
approved these changes
Apr 25, 2025
| .id(subcategory.id) | ||
| } | ||
| } | ||
| .padding(EdgeInsets(top: 4, leading: 24, bottom: 16, trailing: 24)) |
There was a problem hiding this comment.
nit: maybe not super useful since this is all contained in this ViewBuilder, but a constant to keep track of these values (as well as the FlowLayout spacing values above) might be helpful in the future.
| @@ -46,18 +51,24 @@ class FilterCategoryViewModel<T: FilterCategory>: FilterCategoryViewModelType { | |||
| .assign(to: &self.$canReset) | |||
|
|
|||
| self.selectedCategorySubject | |||
| .map { $0?.0 } | |||
There was a problem hiding this comment.
nit: naming these instead of going with the short hand could make this easier to review in the future.
| .receive(on: RunLoop.main) | ||
| .assign(to: &self.$currentCategory) | ||
|
|
||
| self.selectedCategorySubject | ||
| .map { $0?.1 } |
There was a problem hiding this comment.
nit: same shorthand suggestion as above
| // FIXME: https://kickstarter.atlassian.net/browse/MBL-2384 | ||
| // This snapshot test looks wrong, the UI in the app does not have the lines | ||
| // along the left and right sides of the button. This is consistent with | ||
| // other uses of SearchFiltersPillStyle. |
There was a problem hiding this comment.
this one is so interesting
amy-at-kickstarter
added a commit
that referenced
this pull request
Apr 25, 2025
9d3a94d to
92c34eb
Compare
jovaniks
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Screen.Recording.2025-04-23.at.14.05.19.mov
This PR adds subcategories to the search filters view, and updating the the search results page with the results of that filter.
🤔 Why
People wanna filter stuff!
🛠 How
The model for determining selection was updated to include both the selected category and an optional subcategory. This drives the filter selection UI, and determines which pieces to show and highlight.
This is then returned as a category to the existing search API and root level filter view. This handles updating all of the UI correctly.