MBL-2220: (Part one) Update search filters and search view models to support phase 2 search features #2402
+224
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support phase 2 search features
stevestreza-ksr
approved these changes
Apr 24, 2025
| let hasCategory = category != nil | ||
| let hasState = state != SearchFiltersUseCase.defaultStateOption | ||
| private func updatePills() { | ||
| let filterCount = [self.hasCategory, self.hasProjectState].reduce(0) { filterCount, hasFilter in |
There was a problem hiding this comment.
A little hard to scan this quickly to understand what it's doing. I think this is just counting how many conditions are active, so maybe replace this with [self.hasCategory, self.hasProjectState].count(where: { $0 == true })
There was a problem hiding this comment.
Fixed! Good suggestion.
amy-at-kickstarter
added a commit
that referenced
this pull request
Apr 24, 2025
94961d7 to
81bd790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Make some updates to
SearchViewModelandSearchFiltersUseCasefor the new parent filter page:SearchFilterModalTypecase.allto.allFiltersfor clarityclearOptionstoclearedQueryTextto differentiate clearing the search query from clearing filtersSearchFiltersUseCaseTeststo test all of this (and make some updates for clarity, too)🤔 Why
The parent filter page has complex behavior for the "Reset" button. The "Reset" button changes title and behavior based on which page its on top of. All of these changes support that.