8000 [MBL-2387] PLOT Server-Delivered Copy by jovaniks · Pull Request #2408 · kickstarter/ios-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MBL-2387] PLOT Server-Delivered Copy #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

[MBL-2387] PLOT Server-Delivered Copy #2408

merged 3 commits into from
Apr 28, 2025
+8,672 −5,581

Conversation

jovaniks
Copy link
Contributor

📲 What

This PR updates the app to dynamically consume the PLOT-related copy from the new GraphQL fields:

  • pledgeOverTimeCollectionPlanShortPitch
  • pledgeOverTimeCollectionPlanChargeExplanation
  • pledgeOverTimeCollectionPlanChargedAsNPayments

It replaces the localized static Strings with server-delivered, localized copies.

🛠 How

Update PledgePaymentPlansOptionViewModel to use:

  • pledgeOverTimeCollectionPlanShortPitch
  • pledgeOverTimeCollectionPlanChargeExplanation

Update PledgeSummaryViewModel to use pledgeOverTimeCollectionPlanChargedAsNPayments instead of Strings.Charged_as_number_of_payments

👀 See

Payment increments PLOT blurb
image image

✅ Acceptance criteria

  • PLOT components in the checkout screen now consume the new fields.
  • Snapshot tests updated and passing.

@jovaniks jovaniks self-assigned this Apr 28, 2025
scottkicks
scottkicks approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor
@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nativeksr
Copy link
Collaborator
1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@jovaniks jovaniks merged commit 5c95bcd into main Apr 28, 2025
5 checks passed
@jovaniks jovaniks deleted the jluna/MBL-2387/plot-server-copy branch April 28, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevestreza stevestreza stevestreza approved these changes

@scottkicks scottkicks scottkicks approved these changes

@stevestreza-ksr stevestreza-ksr Awaiting requested review from stevestreza-ksr

Assignees

@jovaniks jovaniks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jovaniks @nativeksr @stevestreza @scottkicks
0