8000 [MBL-2231] - [MBL-2199] String translations update by jovaniks · Pull Request #2407 · kickstarter/ios-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MBL-2231] - [MBL-2199] String translations update #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

[MBL-2231] - [MBL-2199] String translations update #2407

merged 1 commit into from
Apr 28, 2025
+210 −166

Conversation

jovaniks
Copy link
Contributor
@jovaniks jovaniks commented Apr 25, 2025 •
edited by jira bot
Loading

📲 What

Update String translations:

  • Sort&Filter: Reset_all_filters
  • Pledge Management: Pledge_label

🛠 How

  • Update strings using make strings
  • Change “Reset All” to the Strings.Reset_All_Filters()
  • Using Strings.Pledge_label() instead of Strings.Pledge() in Pledge management view

👀 See

✅ Acceptance criteria

  • Test PASSED

@jovaniks jovaniks self-assigned this Apr 25, 2025
@jovaniks jovaniks merged commit 273aafd into main Apr 28, 2025
4 checks passed
@jovaniks jovaniks deleted the jluna/MBL-2232-2199/strings-translations branch April 28, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottkicks scottkicks scottkicks approved these changes

@stevestreza-ksr stevestreza-ksr stevestreza-ksr approved these changes

@amy-at-kickstarter amy-at-kickstarter Awaiting requested review from amy-at-kickstarter

Assignees

@jovaniks jovaniks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jovaniks @scottkicks @stevestreza-ksr
0