8000 [MBL-2385] Intersperse Tracking # Cards With Activities by scottkicks · Pull Request #2405 · kickstarter/ios-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MBL-2385] Intersperse Tracking # Cards With Activities #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2025
Merged

[MBL-2385] Intersperse Tracking # Cards With Activities #2405

merged 2 commits into from
Apr 25, 2025
+93 −114

Conversation

scottkicks
Copy link
Contributor
@scottkicks scottkicks commented Apr 25, 2025 •
edited
Loading

…f being in their own section

📲 What

  • Use the sort order of the v1/activities response so that the tracking # cards are interspersed among the other activities and next to their relevant project Activity.
  • Also adds logic to only hide the "Track shipment" button if the trackingURL is nil.

🤔 Why

  • It makes more sense for these cards to be paired with their relevant project activities.
    We also don't want to bury any surveys unnecessarily.
  • If the trackingURL is nil, it will still be useful for backers to know their tracking numbers and that their rewards have shipped. Rather than hiding the entire view.

🛠 How

  • Use the existing data source .load method, that is already populating the activities section of the table, to load up the shipped activities.
  • Remove the code that handles loading these new activities into a separate rewardTracking section.

👀 See

Before 🐛 After 🦋
Simulator Screen Recording - iPhone 15 Pro 17 5 - 2025-04-23 at 09 31 40 Simulator Screen Recording - iPhone 15 Pro 17 5 - 2025-04-25 at 09 28 45

✅ Acceptance criteria

  • Reward tracking cards are interspersed amongst activities and are paired with their relevant projects
  • Tracking cards still display expected data, and the "track shipment" button functions as expected.

@scottkicks scottkicks self-assigned this Apr 25, 2025
@scottkicks scottkicks force-pushed the scott/tracking-number-sort-order branch from e16b4e0 to 75c70c1 Compare April 25, 2025 14:30
@scottkicks scottkicks marked this pull request as ready for review April 25, 2025 14:51
jovaniks
jovaniks approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor
@jovaniks jovaniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@scottkicks scottkicks merged commit e40aff9 8444 into main Apr 25, 2025
5 checks passed
@scottkicks scottkicks deleted the scott/tracking-number-sort-order branch April 25, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-at-kickstarter amy-at-kickstarter amy-at-kickstarter approved these changes

@jovaniks jovaniks jovaniks approved these changes

@stevestreza-ksr stevestreza-ksr Awaiting requested review from stevestreza-ksr

Assignees

@scottkicks scottkicks

Labels
pledge-management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottkicks @amy-at-kickstarter @jovaniks
0