[MBL-2198] Deeplink fallback: backing/details → survey_responses #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prompts Replaces occurrences of `backing/details` with `backing/survey_responses` when matching routes to prevent re-authentication issues triggered by backend restrictions in the WebView. This fallback was previously applied in Pledge Management flow as well: - Backing.swift#L15 - ViewPledgeUseCase.swift#L43 Includes tests to ensure `backing/details` maps correctly to `survey_responses`.
backing/details deeplinks to avoid WebView auth …
stevestreza-ksr
approved these changes
Apr 25, 2025
amy-at-kickstarter
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fallback logic for deeplinks: replaces
/backing/detailswith/backing/survey_responsesto avoid WebView login prompts / white screen.🛠 How
Navigation.swiftinside theprojectSurveyroute match.NavigationTests.swiftto assert the fallback behavior explicitly.This same workaround exists in the Pledge Management flow:
👀 See
✅ Acceptance criteria
/backing/detailspath opens the WebView with/backing/survey_responsesinstead./backing/survey_responsespath works as expected and loads the WebView successfully.⏰ TODO
/backing/detailsonce backend auth issue is resolved.