MBL-2353: Fix off-by-one error in search results #2392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e48771 to
8c48adf
Compare
jovaniks
approved these changes
Apr 21, 2025
scottkicks
approved these changes
Apr 21, 2025
| @@ -3,6 +3,8 @@ import Library | |||
| import Prelude | |||
| import UIKit | |||
|
|
|||
| typealias TitleRow = Void | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fix an off-by-one error when tapping on results in search.
🤔 Why
This happened because I added the search results title as a cell, instead of as a section header - so
indexPath.rowbecame off-by-one.I double-checked and this bug doesn't exist in the release app, only the beta version.