[MBL-2366] Fix update payment method for PLOT pledges #2398
Conversation
paymentSourceId or applePay when change payment meth…| // Check if this is a change payment method and PLOT pledge; if so, only include paymentSourceId or applePay. | ||
| let isChangePaymentMethodAndPlot = updateBackingData | ||
| .pledgeContext == .changePaymentMethod && updateBackingData.backing.paymentIncrements.count > 0 | ||
|
|
||
| let shouldOmitAmount = updateBackingData.backing | ||
| .isLatePledge || isFixPledge || isChangePaymentMethodAndPlot | ||
| let shouldOmitLocationAndRewards = isFixPledge || isChangePaymentMethodAndPlot | ||
|
|
||
| return UpdateBackingInput( | ||
| amount: (updateBackingData.backing.isLatePledge || isFixPledge) ? nil : pledgeTotal, | ||
| amount: shouldOmitAmount ? nil : pledgeTotal, | ||
| applePay: isApplePay ? updateBackingData.applePayParams : nil, | ||
| id: backingId, | ||
| locationId: isFixPledge ? nil : locationId, | ||
| locationId: shouldOmitLocationAndRewards ? nil : locationId, | ||
| paymentSourceId: isApplePay ? nil : updateBackingData.paymentSourceId, | ||
| rewardIds: isFixPledge ? nil : rewardIds, | ||
| rewardIds: shouldOmitLocationAndRewards ? nil : rewardIds, | ||
| setupIntentClientSecret: updateBackingData.setupIntentClientSecret |
There was a problem hiding this comment.
The multiple ternary operators and conditional properties are starting to make this constructor method a bit messy and convoluted.
It could be worth considering making a new constructor method specific to this use case instead of handling the different cases in this one.
There was a problem hiding this comment.
I’ll take care of this refactor in a dedicated clean-up ticket. I’ll also use that ticket to address a related fix needed for late pledges.
More details in the clean-up ticket.
This behavior changed due to a recent backend update! That’s why it didn’t surface during the original QA sessions. |
…od for PLOT pledges
8c8370f to
1bd2bff
Compare
📲 What
Fixes the Feature disabled error shown when attempting to change the payment method for PLOT pledges by ensuring only the
paymentSourceIdorapplePayfield is sent, and excludingrewardIds,amount, andlocationId.🤔 Why
The backend expects only
paymentSourceIdorapplePayto be present in the payload when updating payment method for PLOT pledges. Sending additional fields likerewardIdscauses the endpoint to reject the request with a Feature disabled error.🛠 How
isChangePaymentMethodAndPlot.amount,rewardIds, andlocationIdfrom theUpdateBackingInputpayload when the context is.changePaymentMethodand the pledge is a PLOT type.👀 See
✅ Acceptance criteria
⏰ TODO