[MBL-2360] Show Tracking Number Cards In Activity #2397
Merged
+135
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* verified that we don't want this anymore with design
| @@ -50,6 +50,9 @@ internal final class ActivitiesDataSource: ValueCellDataSource { | |||
| self.appendRow(value: activity, cellClass: ActivityFriendFollowCell.self, toSection: section) | |||
| case .cancellation, .failure, .launch, .success, .suspension: | |||
| self.appendRow(value: activity, cellClass: ActivityProjectStatusCell.self, toSection: section) | |||
| case .shipped: | |||
| // shipped data is loaded via `load(rewardTrackingData:...)` below on line: 62 | |||
There was a problem hiding this comment.
Can you add an assert(false) here ? That way we'll know if this is called by accident.
There was a problem hiding this comment.
I don't think this can be called by accident. This will technically still be called when there are .shipped activities, but we're just handling that case in a separate load method.
amy-at-kickstarter
approved these changes
Apr 23, 2025
| self.rewardTrackingData = self.activities | ||
| .map { $0.first?.project } | ||
| .skipNil() | ||
| self.rewardTrackingData = self.activities.signal |
There was a problem hiding this comment.
Can you add a unit test that makes sure self.rewardTrackingData is set when there's the correct activity type in the response?
<
8000
/div>
f548e8e to
d8509f1
Compare
jovaniks
requested changes
Apr 23, 2025
jovaniks
reviewed
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Exposes a new Activity.Category type as well as trackingNumber and and trackingUrl properties retrieved from our
/v1/activitiesendpoint and uses them to populate our new PM Tracking Number Cards.🤔 Why
We want to show users who have backed a project via Pledge Management who chose a shippable reward that their reward has shipped and that they can easily open up their shipment tracking info/status in a browser.
🛠 How
The plumbing for showing these new cards has already been done!
So, all we need to do is:
trackingUrlwhen the "Track shipment" button is tapped.👀 See
FYI: The number and URL for this test project is "testing!" and a testing url.
✅ Acceptance criteria