Split FilterCategoryView into new/old versions for search phase 2 #2396
+229
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copy of FilterCategoryViewTest.
There was a problem hiding this comment.
Copy of FilterCategoryView.
40c8b3d to
8af233e
Compare
| @@ -9,12 +9,6 @@ struct FilterCategoryView<T: FilterCategory>: View { | |||
|
|
|||
| var body: some View { | |||
| VStack(spacing: 0) { | |||
| if !featureSearchFilterByProjectStatusEnabled() { | |||
There was a problem hiding this comment.
FilterCategoryView is only used in the new flow, so it doesn't need this feature flag check any more
| @@ -228,7 +228,7 @@ internal final class SearchViewController: UITableViewController { | |||
| selectedCategory: self.viewModel.outputs.selectedFilters.category | |||
| ) | |||
|
|
|||
| let filterView = FilterCategoryView( | |||
| let filterView = FilterCategoryView_PhaseOne( | |||
There was a problem hiding this comment.
See above - this is used when the feature flag is off.
b49272f to
e2f8f0b
Compare
scottkicks
approved these changes
Apr 23, 2025
stevestreza-ksr
approved these changes
Apr 24, 2025
jovaniks
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Rename
FilterCategoryViewtoFilterCategoryView_PhaseOneand make a copy for Phase Two.🤔 Why
I've been working on creating the new root filter view. I thought I was going to be able to do it without making substantial changes to
FilterCategoryView, but eventually I realized that wasn't going to work.This will let us keep Phase 2 fully behind a feature flag. When the phase 2 flag is off (
featureSearchFilterByProjectStatusEnabled()), the oldFilterCategoryView_PhaseOnewill be used. The newFilterCategoryViewwill be used when the flag is on.🛠 How
Copy-paste.