[MBL-2317] View Your Pledge Web View #2380
Merged
+173
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevestreza-ksr
approved these changes
Apr 10, 2025
Comment on lines
32
to
34
| let urlString = | ||
| "\(AppEnvironment.current.apiService.serverConfig.webBaseUrl)/projects/\($0.creator.id)/\($0.slug)/backing/details" | ||
| return URL(string: urlString) |
There was a problem hiding this comment.
There's a function getProjectBackingDetailsURL that appears to do this, can you move this to a publicly available function somewhere and use it here?
There was a problem hiding this comment.
I added ProjectURLBuilder with a public version of getProjectBackingDetailsURL.
ec52370 to
5aec42e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Creates a new web view controller that will display a user's backing details.
🤔 Why
For backers who pledged to a campaign and completed PM or who just completed PM, we'll show a web view when they want to see their backing details.
This is a crunch time approach. There are plans to update our native screen with PM backing details, etc., once we're out of crunch time 🤞.
🛠 How
Project.This is just the view controller. The next PR will wire it up and use the new
Backing.Orderobject, and the feature flag, to determine when to show this web view and when to show the existing native screen.The entry points will include the Project Page and Messages.
Checkout the SPIKE for more details
👀 See
I replaced the creator profile webview with this new one for testing purposes.
✅ Acceptance criteria
⏰ TODO