8000 Fix beta build failure due to PBX sync group in PledgeManagement by jovaniks · Pull Request #2388 · kickstarter/ios-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix beta build failure due to PBX sync group in PledgeManagement #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Fix beta build failure due to PBX sync group in PledgeManagement #2388

merged 1 commit into from
Apr 16, 2025
+23 −12

Conversation

jovaniks
Copy link
Contributor

📲 What

Fixes a crash when running fastlane for the beta build by converting the PledgeManagement group from a sync group (PBXFileSystemSynchronizedRootGroup) to a standard folder reference in Xcode.

🛠 How

  • In Xcode, updated the PledgeManagement group to use a regular folder reference instead of a sync group.
  • This ensures compatibility with the tooling used by fastlane and resolves the CI crash.

👀 See

-CircleCI

✅ Acceptance criteria

  • Beta build succeeds on CI
  • Project compiles and runs as expected
  • No unintended changes to the project file

@jovaniks jovaniks self-assigned this Apr 15, 2025
@jovaniks jovaniks force-pushed the jluna/hotfix/beta-build-failed branch from d78129c to f96a999 Compare April 15, 2025 23:38
@jovaniks jovaniks requested a review from scottkicks April 15, 2025 23:39
@jovaniks jovaniks merged commit 2498149 into main Apr 16, 2025
5 checks passed
@jovaniks jovaniks deleted the jluna/hotfix/beta-build-failed branch April 16, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevestreza-ksr stevestreza-ksr stevestreza-ksr approved these changes

@amy-at-kickstarter amy-at-kickstarter Awaiting requested review from amy-at-kickstarter

@scottkicks scottkicks Awaiting requested review from scottkicks

Assignees

@jovaniks jovaniks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jovaniks @stevestreza-ksr
0