8000 Add accent/gray/subtle and border/active to new design system colors by amy-at-kickstarter · Pull Request #2385 · kickstarter/ios-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add accent/gray/subtle and border/active to new design system colors #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

amy-at-kickstarter
Copy link
Contributor

📲 What

  • Add two colors to our design system
  • Add a default size of nil to swiftUIFont, for convenience

🤔 Why

I need these for the search filter pill buttons.

{
"colors" : [
{
"color" : {
Copy link
8000
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these are missing dark mode versions - waiting for those values from Alison.

@amy-at-kickstarter amy-at-kickstarter marked this pull request as ready for review April 15, 2025 16:53
Copy link
Contributor
@jovaniks jovaniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄

@@ -45,7 +45,7 @@ extension CustomFont {
/// Converts the custom font to a SwiftUI `Font`.
/// - Parameter size: The font size to apply. If `nil`, the default size for the font will be used.
/// - Returns: A SwiftUI `Font` created from the custom `UIFont`.
public func swiftUIFont(size: CGFloat?) -> Font {
public func swiftUIFont(size: CGFloat? = nil) -> Font {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!!!

@amy-at-kickstarter amy-at-kickstarter merged commit 54991d3 into main Apr 15, 2025
5 checks passed
@amy-at-kickstarter amy-at-kickstarter deleted the feat/adyer/add-some-colors branch April 15, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0