[MBL-2264] [3 of 3] Show a partial project view when opening a similar project #2378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1aad9da to
66b7e9f
Compare
Generated by 🚫 Danger |
amy-at-kickstarter
approved these changes
Apr 10, 2025
Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift
Show resolved
Hide resolved
...ter-iOS/Features/ProjectPage/Datasource/Datasource/ProjectPageViewControllerDataSource.swift
Show resolved
Hide resolved
f0858f8 to
ad001a9
Compare
898cfa3 to
77da385
Compare
Base automatically changed from
stevestreza/project-page-refactor/project-pamphlet-graphql
to
main
April 14, 2025 18:33
264c3b0 to
8d712b0
Compare
scottkicks
approved these changes
Apr 21, 2025
1a828e5 to
8a3b3ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 3 of 3 PRs for refactoring the project page to support an intermediate loading state from a partial project.
This merges into the second PR's branch (which will resolve back to main once it all merges); this should not merge until then.
📲 What
This PR adds partial loading support to the Project Page with an initial project. When it loads with an initial project, the first cell loads with it.
🤔 Why
Right now, opening a card from Similar Projects shows a completely blank screen. This UX would be better if we could at least show the main card for the project while the rest of the data loads.
🛠 How
Building on the last two PRs, the Project Page view is updated with so that the
Either<Project, Param>type is updated with a project page-specific Param type (which includes an optional initial configuration). These use the new protocol types from the last PR.Once this new param is loaded into the project page, if an initial configuration is included, that cell is loaded into the table and shown.
Additionally, the nav bar is updated to show the Overview tab while the remainder of the tabs load.
👀 See
Vision doc for multiple model types
✅ Acceptance criteria