MBL-2075: Add Backings dashboard as its own tab #2306
Conversation
f11a6b7 to
4e1694d
Compare
- Disable badges temporarily - Fix failing tests - Delete unused tab bar item type
4e1694d to
a40a305
Compare
| @@ -5,14 +5,13 @@ import Library | |||
| import Stripe | |||
| import SwiftUI | |||
|
|
|||
| public class PPOContainerViewController: PagedContainerViewController<PPOContainerViewController.Page>, | |||
There was a problem hiding this comment.
I didn't delete PagedContainerViewController - I suspect it will come back into use soon enough. I set myself a calendar reminder for +3 months to delete it if nobody has needed it by then.
There was a problem hiding this comment.
For PLOT we started a plot-tech-debt epic early on to help track stuff like this. Totally up to you though!
There was a problem hiding this comment.
Ticket would be ideal yeah
| return BackerDashboardViewController.instantiate() | ||
| case .profile(isLoggedIn: false): | ||
| return LoginToutViewController.configuredWith(loginIntent: .loginTab) | ||
| case .backings(isLoggedIn: false): |
There was a problem hiding this comment.
This is the main change here - logged out users will see the EmptyStatesViewController, installed directly in the tab.
| @@ -5,14 +5,13 @@ import Library | |||
| import Stripe | |||
| import SwiftUI | |||
|
|
|||
| public class PPOContainerViewController: PagedContainerViewController<PPOContainerViewController.Page>, | |||
There was a problem hiding this comment.
For PLOT we started a plot-tech-debt epic early on to help track stuff like this. Totally up to you though!
| @@ -205,6 +205,8 @@ public final class RootTabBarViewController: UITabBarController, MessageBannerVi | |||
| switch item { | |||
| case let .home(index): | |||
| _ = self.tabBarItem(atIndex: index) ?|> homeTabBarItemStyle | |||
| case let .backings(index): | |||
| _ = self.tabBarItem(atIndex: index) ?|> backingsTabBarItemStyle | |||
There was a problem hiding this comment.
Is it worth moving away from prelude operators like this as we come across them?
| @@ -5,14 +5,13 @@ import Library | |||
| import Stripe | |||
| import SwiftUI | |||
|
|
|||
| public class PPOContainerViewController: PagedContainerViewController<PPOContainerViewController.Page>, | |||
There was a problem hiding this comment.
Ticket would be ideal yeah
| case .backings(isLoggedIn: false): | ||
| // Backings and Activity use the same empty state | ||
| fallthrough | ||
| case .activities(isLoggedIn: false): |
There was a problem hiding this comment.
Can this be replaced with case .backings(isLoggedIn: false), .activities(isLoggedIn: false):? Makes it a little clearer that both of these cases go to the same place.
| self.setBadgeValueAtIndexValue.assertLastValue("", "Turning on PPO should show empty badge icon") | ||
| self.setBadgeValueAtIndexValue.assertLastValue( | ||
| nil, | ||
| "Turning on PPO should show a badge, eventually, but that is coming in a follow-up PR." |
There was a problem hiding this comment.
Add a FIXME that links to the ticket that will fix this so it can be searched for more easily
| self.setBadgeValueAtIndexIndex.assertValues([1, 1]) | ||
| } | ||
| } | ||
| /* |
There was a problem hiding this comment.
Instead of commenting this out, can you change the function signature to func disabled_ testPPOTabBarBadging_FeatureFlagEnabledWithoutPersistence() { … } or something like that? It'll leave the code present (so the compiler can check it and any refactors will be able to pick it up) but the unit tests wont run.
📲 What
Add Backings Dashboard as its own tab in the root tab bar controller.
🤔 Why< 8000 /h1>
This is part of the UI updates for PPO V2!
🛠 How
RootViewControllerDatatype,.backings, and delete old type,.pledgedProjectsAndActivitiesActivitiesViewControllerto place anEmptyStatesViewControllerdirectly in the tab bar when the user is logged out. Then do the same thing forPPOContainerViewControllerin its new tab. Adding the empty state controller directly to the tab bar ensures the layout is identical between the Backings and Activity tabs.PPOContainerViewControllerto remove the top paged controller