[🐛] NT-1193 Pledge button disabled bug #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n. Added distinctUntilChanged to fix broken tests.
Arkariang
approved these changes
Apr 23, 2020
eoji
added a commit
that referenced
this pull request
Apr 23, 2020
- Instead of depending on `initialCardSelection` which won't emit if a user has no stored cards, using `selectedCardAndPosition` to determine if `pledgeButtonIsEnabled` should emit - Added `distinctUntilChanged` to fix broken tests (cherry picked from commit 6fe5c16)
eoji
added a commit
that referenced
this pull request
May 7, 2020
* Bumping version names in prep for 2.6.0 RC * Updating version codes post 2.6.0 RC creation. * [🐛] NT-1193 Pledge button disabled bug(#848) - Instead of depending on `initialCardSelection` which won't emit if a user has no stored cards, using `selectedCardAndPosition` to determine if `pledgeButtonIsEnabled` should emit - Added `distinctUntilChanged` to fix broken tests (cherry picked from commit 6fe5c16) * Bumping version codes post new 2.6.0 RC creation with NT-1193 bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes bug where pledge button was still disabled after user added their first payment method.
🤔 Why
So people can pledge after adding their first stored card!
🛠 How
initialCardSelectionwhich won't emit if a user has no stored cards, usingselectedCardAndPositionto determine ifpledgeButtonIsEnabledshould emitdistinctUntilChangedto fix broken tests👀 See
📋 QA
Steps to repro:
Story 📖
NT-1193