[🌚] NT-1139 Reset device ID in Internal Tools #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New `Worker` that resets the Firebase instance ID in the background and sends broadcast when it's successful. # `InternalToolsActivity` - Added `resetDeviceIdReceiver` to listen for when `ResetDeviceIdWorker` is successful - Added `showDeviceId` method to toggle hiding the device id while it's being reset - # `internal_tools_layout.xml` - Added `device_id_loading_indicator` and `reset_device_id` Button
justinswart
approved these changes
Apr 20, 2020
jgsamudio
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Added a button to reset the device ID in the Internal Tools
🤔 Why
It will make testing a lot easier!
🛠 How
ResetDeviceIdWorkerWorkerthat resets the Firebase instance ID in the background and sends a broadcast when it's successful.InternalToolsActivityresetDeviceIdReceiverto listen for whenResetDeviceIdWorkeris successfulshowDeviceIdmethod to toggle hiding the device id while it's being resetinternal_tools_layout.xmldevice_id_loading_indicatorandreset_device_idButtonbuild.gradle
I had to add another repo for Apollo because it was causing the build to fail. More ammo for justification to get rid of it.
👀 See
📋 QA
Smash that reset button.
Story 📖
NT-1139