[🛤] NT-936 Creator Details Clicked event #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/kickstarter/viewmodels/ProjectHolderViewModel.java
# Conflicts: # app/src/main/res/drawable/rect_grey_500_loading.xml # app/src/main/res/layout-land/project_media_header.xml # app/src/main/res/layout/loading_placeholder_creator_info.xml
jgsamudio
approved these changes
Mar 16, 2020
ifbarrera
approved these changes
Mar 16, 2020
|
|
||
| fullProjectDataAndCurrentUser | ||
| .compose<Pair<ProjectData, User?>>(takeWhen(creatorInfoClicked)) | ||
| .filter { it.first.project().isLive && !it.first.project().isBacking } |
There was a problem hiding this comment.
Do we not show the creator info if you've already backed the project? 🤔
There was a problem hiding this comment.
This is only for tracking. I'm only tracking this for live not backed projects. Otherwise, I think the experiment would have really low conversion because it would fire for ended and already backed projects? But not sure because the experiment process has been pretty confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Added
Creator Details Clickedevent for Optimizely.🤔 Why
So we can get those sweet funnel numbers.
🛠 How
OptimizelyEvent.CREATOR_DETAILS_CLICKEDwith value"Creator Details Clicked"CREATOR_DETAILS_CLICKEDwhen the creator details are clicked inProjectViewModel.CREATOR_DETAILS_CLICKEDis tracked when the button is clicked on live and not backed projects only.👀 See
Nothing to see.
📋 QA
Check your local logs!
Check your data dog logs!
Story 📖
NT-936