[⏳] NT-890 Syncing Optimizely every 10 minutes #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
reviewed
Feb 18, 2020
| @@ -649,6 +650,8 @@ ExperimentsClientType provideOptimizely(final @ApplicationContext @NonNull Conte | |||
|
|
|||
| final OptimizelyManager optimizelyManager = OptimizelyManager.builder() | |||
| .withSDKKey(optimizelyKey) | |||
| .withEventDispatchInterval(60L * 10L) | |||
There was a problem hiding this comment.
What's the default event dispatch interval? 10 minutes seems high, I'd imagine we want to dispatch events fairly frequently?
There was a problem hiding this comment.
it's -1 lol
// -1 will cause the background download to not be initiated.
private long datafileDownloadInterval = -1L;
// -1 will cause the background download to not be initiated.
private long eventDispatchInterval = -1L;
ifbarrera
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adding datafile and event dispatch intervals to Optimizely.
🤔 Why
So we get the latest data file and events dispatched every 10 minutes.
🛠 How
Added datafile and event dispatch intervals to Optimizely client with a value of 10 minutes per example: https://docs.developers.optimizely.com/full-stack/docs/initialize-sdk-android#section-example
👀 See
Nothing 2 c
📋 QA
Change your variant and wait...10 minutes.
Story 📖
NT-890