[🙏🏾] NT-848 Thanks Page Viewed event #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `LakeEvent.THANKS_PAGE_VIEWED` with value `"Thanks Page Viewed"` - `PledgeFragmentViewModel.Output.showPledgeSuccess` now emits a pair of `CheckoutData` and `PledgeData` - `PledgeFragment.PledgeDelegate.pledgeSuccessfullyCreated` now takes in a pair of `CheckoutData` and `PledgeData` - Added `IntentKey.CHECKOUT_DATA` and `PLEDGE_DATA` - `ThanksActivity` is now started with `CheckoutData` and `PledgeData` to pass through to event - Tracking THANKS_PAGE_VIEWED in `ThanksViewModel` - Updated tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adding
Thanks Page Viewedevent.🤔 Why
We have new Back a Project events.
🛠 How
Koala.trackThanksPageViewedLakeEvent.THANKS_PAGE_VIEWEDwith value"Thanks Page Viewed"PledgeFragmentViewModel.Output.showPledgeSuccessnow emits a pair ofCheckoutDataandPledgeDataPledgeFragment.PledgeDelegate.pledgeSuccessfullyCreatednow takes in a pair ofCheckoutDataandPledgeDataIntentKey.CHECKOUT_DATAandPLEDGE_DATAThanksActivityis now started withCheckoutDataandPledgeDatato pass through to eventTHANKS_PAGE_VIEWEDinThanksViewModelThanksViewModelTest.LakeEventfor a successful checkout👀 See
No visual changes.
📋 QA
So many ways 2 QA:
ktkthe staging lakeLogcatin Android Studiodevproject in AmplitudeStory 📖
NT-848