8000 [🕸] NT-875 Campaign details webview by eoji · Pull Request #750 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[🕸] NT-875 Campaign details webview #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2020
Merged

[🕸] NT-875 Campaign details webview #750

merged 1 commit into from
Feb 15, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Feb 14, 2020

📲 What

Added a new screen explicitly for the campaign details.

🤔 Why

Prep for an experiment ⚗️

🛠 How

  • Created new CampaignDetailsActivity to open campaign in webview. It has one output url that's the URL of the project's campaign.
  • Now using UrlUtils.appendPath in Project url helper methods.
    Tests.

👀 See

Looks EYE dentical

Before 🐛 After 🦋
device-2020-02-14-180421 2020-02-14 18_06_38 device-2020-02-14-180421 2020-02-14 18_06_38

📋 QA

Smash that read more button

Story 📖

NT-875

Now using UrlUtils in Project url helper methods.
Tests.
@eoji eoji merged commit fb44ee9 into master Feb 15, 2020
@eoji eoji deleted the NT-875 branch February 15, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0