[🧽🐨] NT-926 Koala clean up #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved RefTag properties to helper method in KoalaUtils.
This was referenced Feb 24, 2020
jgsamudio
reviewed
Feb 24, 2020
| @@ -226,6 +218,20 @@ private KoalaUtils() {} | |||
| return MapUtils.prefixKeys(properties, prefix); | |||
| } | |||
|
|
|||
| public static @NonNull Map<String, Object> refTagProperties(final @Nullable RefTag intentRefTag, final @Nullable RefTag cookieRefTag) { | |||
| return new HashMap<String, Object>() { | |||
| { | |||
There was a problem hiding this comment.
Do you need this extra bracket?
There was a problem hiding this comment.
Yes! It's the init block of the HashMap
jgsamudio
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Lil Koala refactor, my next mix tape.
🤔 Why
We're about to hit the 800 line limit in
Koala.javaso I cleaned it up.🛠 How
KoalaUtils.refTagPropertiesfor setting the"session_ref_tag"and"session_referrer_credit"properties.Koala.javatrackFacebookLoginSuccesstrackCheckoutNexttrackCheckoutCanceltrackCheckoutLoadFailedtrackCheckoutCancelShareSheettrackCheckoutShareFinishedtrackCancelProjectShareSheettrackShowProjectFacebookShareViewtrackShowProjectTwitterShareViewtrackProjectFacebookSharetrackProjectTwitterShare👀 See
📋 QA
The tests are passing™.
Story 📖
NT-926