8000 [ℹ️] NT-805 BackingFragment reward card IA by eoji · Pull Request #741 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ℹ️] NT-805 BackingFragment reward card IA #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

[ℹ️] NT-805 BackingFragment reward card IA #741

merged 1 commit into from
Feb 13, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Feb 12, 2020 •
edited
Loading

📲 What

Reverting hiding reward IA in view/manage pledge screen. It will now display the backers count and estimated delivery.

🤔 Why

They were hidden in #613 but they're back now.

🛠 How

  • Added start and end margin to BackingFragment root view.
  • Removed special inset behavior for NativeCheckoutRewardCardViewHolder except for Select button

👀 See

After 🦋 Before 🐛
Screenshot_1581524534 Screenshot_20200212-112328

📋 QA

View or manage your pledge.

Story 📖

NT-805

@eoji eoji added the UI 🎨 label Feb 12, 2020
@eoji eoji requested a review from a team February 12, 2020 16:28
setsun
setsun approved these changes Feb 12, 2020
View reviewed changes
Copy link
@setsun setsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eoji eoji merged commit 8f265a6 into master Feb 13, 2020
@eoji eoji deleted the NT-805 branch February 13, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setsun setsun setsun approved these changes

Assignees
No one assigned
Labels
UI 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @setsun
0