8000 [👋🏾] NT-799 Removing mini reward animation by eoji · Pull Request #747 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[👋🏾] NT-799 Removing mini reward animation #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2020
Merged

[👋🏾] NT-799 Removing mini reward animation #747

merged 4 commits into from
Feb 21, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Feb 14, 2020 •
edited by jira bot
Loading

📲 What

Getting rid of the mini reward animation

🤔 Why

No one can read that tiny text!

🛠 How

  • Deleted ScreenLocation.
  • Removed all inputs and outputs dependent on animation.
  • Updated tests.

👀 See

After 🦋 Before 🐛
device-2020-02-14-151427 2020-02-14 15_23_03 device-2020-02-14-152343 2020-02-14 15_24_16

📋 QA

Select a reward.

Story 📖

NT-799

eoji added 2 commits February 14, 2020 15:11
@eoji
Removing mini reward animation:
198d505 
Deleted ScreenLocation.
Removed all inputs and outputs for animation.
Updated tests.
@eoji
missed snapshotIsGone assertions
5820cc8
@eoji eoji added the UI 🎨 label Feb 14, 2020
@eoji eoji requested a review from a team February 14, 2020 20:28
@eoji eoji mentioned this pull request Feb 14, 2020
Merged
imightbeamy
imightbeamy approved these changes Feb 21, 2020
View reviewed changes
Copy link
@imightbeamy imightbeamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

eoji added 2 commits February 21, 2020 10:40
@eoji
Merge branch 'master' into NT-799
bf8cdbc 
# Conflicts:
#	app/src/main/java/com/kickstarter/ui/activities/ProjectActivity.kt
@eoji
fixing imports after merging in master
8a2a01d
@eoji eoji merged commit 8437790 into master Feb 21, 2020
eoji added a commit that referenced this pull request Feb 21, 2020
@eoji
Revert "[👋🏾] NT-799 Removing mini reward animation (#747)"
4b26a88 
This reverts commit 8437790.
@eoji eoji deleted the NT-799 branch February 21, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imightbeamy imightbeamy imightbeamy approved these changes

Assignees
No one assigned
Labels
UI 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @imightbeamy
0