10000 [🛍] NT-847 Pledge Submit Button Clicked event by eoji · Pull Request #745 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[🛍] NT-847 Pledge Submit Button Clicked event #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2020
Merged

[🛍] NT-847 Pledge Submit Button Clicked event #745

merged 5 commits into from
Feb 14, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Feb 14, 2020 •
edited
Loading

📲 What

Adding Pledge Submit Button Clicked event.

🤔 Why

We have new Back a Project events.

🛠 How

  • Added LakeEvent. PLEDGE_SUBMIT_BUTTON_CLICKED with value "Pledge Submit Button Clicked"
  • Added Koala. trackPledgeSubmitButtonClicked
  • Added CheckoutData and CheckoutDataFactory model to hold data needed for Checkout properties group
  • Tracking when a user clicks the "Pledge" button in PledgeFragmentViewModel
  • Added tests in PledgeFragmentViewModelTest
  • Added LakeTest for checkout properties

bug

  • Fixed bug where Project Page Pledge Button Clicked event fired after user backed project because take(1) was used.

property update

  • Moved reward_estimated_delivery_on and reward_title to pledge property group.

👀 See

No visual changes.

📋 QA

So many ways 2 QA:

  • ktk the staging lake
  • check the Logcat in Android Studio
  • Look at the dev project in Amplitude

Story 📖

NT-847

eoji added 4 commits February 13, 2020 17:32
@eoji
wip checkout properties
593433a
@eoji
added LakeTest for Pledge Submit Button Clicked
88f6397
@eoji
Merge branch 'master' into NT-847
e977619 
# Conflicts:
#	app/src/main/java/com/kickstarter/libs/Koala.java
#	app/src/main/java/com/kickstarter/libs/LakeEvent.kt
#	app/src/main/java/com/kickstarter/libs/utils/KoalaUtils.java
#	app/src/main/java/com/kickstarter/viewmodels/PledgeFragmentViewModel.kt
@eoji
nl
dab8bdb 
updated PledgeFragmentViewModelTest
fixed bug with Project Page Pledge Button Clicked
@eoji eoji requested a review from Scollaco February 14, 2020 14:02
Scollaco
Scollaco approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor
@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@eoji eoji merged commit 99b760b into master Feb 14, 2020
@eoji eoji deleted the NT-847 branch February 14, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scollaco Scollaco Scollaco approved these changes

Assignees
No one assigned
Labels
bug 🐛 events 🛤
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @Scollaco
0