8000 [💳] NT-846 Checkout Payment Page Viewed event by eoji · Pull Request #744 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[💳] NT-846 Checkout Payment Page Viewed event #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2020
Merged

[💳] NT-846 Checkout Payment Page Viewed event #744

merged 2 commits into from
Feb 14, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Feb 13, 2020

📲 What

Adding Checkout Payment Page Viewed event.

🤔 Why

We have new Back a Project events.

🛠 How

  • Added LakeEvent.CHECKOUT_PAYMENT_PAGE_VIEWED with value "Project Page Pledge Button Clicked"
  • Added KoalaUtils.pledgeDataProperties since we also pass the same data for the Select Reward Button Clicked event
  • Added Koala.trackCheckoutPaymentPageViewed
  • Tracking when a user views the pledge screen of an unbacked project
  • Updated tests in PledgeFragmentViewModelTest

👀 See

No visual changes.

📋 QA

So many ways 2 QA:

  • ktk the staging lake
  • check the Logcat in Android Studio
  • Look at the dev project in Amplitude

Story 📖

NT-846

eoji added 2 commits February 13, 2020 15:58
Added LakeEvent.CHECKOUT_PAYMENT_PAGE_VIEWED
Trackig CHECKOUT_PAYMENT_PAGE_VIEWED when user opens PledgeFragment of an unbacked project.
Updated PledgeFragmentViewModelTest.
@eoji eoji requested a review from justinswart February 13, 2020 21:09
@eoji eoji merged commit 2c85996 into master Feb 14, 2020
@eoji eoji deleted the NT-846 branch February 14, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0