8000 [👩‍👧] NT-839 Adding parentName to Category model by eoji · Pull Request #733 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[👩‍👧] NT-839 Adding parentName to Category model #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

[👩‍👧] NT-839 Adding parentName to Category model #733

merged 1 commit into from
Feb 4, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Feb 4, 2020 •
edited by jira bot
Loading

📲 What

Adding parentName to Category model

🤔 Why

So we can track a subcategory's parent.

🛠 How

  • Added parentName field to Category model
  • Using parentName to populate project_category in Project group properties.
  • Added parentName to helper Categorys in CategoryFactory.

👀 See

Screen Shot 2020-02-04 at 12 07 53 PM

📋 QA

  • ktk the staging lake
  • check the Logcat in Android Studio
  • Look at the dev project in Amplitude

Story 📖

NT-839

@eoji
Adding parentName field to Category model. Using it in KoalaUtils.pro…
faa1e89 
…jectProperties.

Also added it to CategoryFactory.
@eoji eoji requested a review from justinswart February 4, 2020 17:09
@eoji eoji merged commit de88ba6 into master Feb 4, 2020
@eoji eoji deleted the NT-839 branch February 4, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinswart justinswart justinswart approved these changes

Assignees
No one assigned
Labels
events 🛤
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @justinswart
0