[🔮] Optimizely X; pledge_cta_copy experiment support #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it since that code still exists). Added Optimizely X library. Added OptimizelyExperiment class to support experiments and generic variants. Added ExperimentUtils for Optimizely attributes. Added support for pledge_cta_copy experiment in ProjectViewModel. ProjectViewUtils.pledgeActionButtonText can now also take in an Optimizely variant. Added ExperimentsClientType interface to handle experiment clients. OptimizelyExperimentsClient is real implementation. MockExperimentsClientType is test implementation. Added ExperimentsClientType to Environment. Initializing Optimizely in ApplicationModule. Fixed bug in UnregisterService where FirebaseInstanceId token was not recycled.
justinswart
approved these changes
Feb 3, 2020
Perhaps just that tests aren't passing? 😬 |
…egistering push token on log out.
|
Marking this as blocked until the 2.2.0 RC is cut |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friendly request to review: #730 so that these tests can pass.
📲 What
Adding
pledge_cta_copyexperiment using Optmizely X.🤔 Why
🔮
🛠 How
build.gradleOptimizelyExperimentclass to support experiments and generic variants.ExperimentsClientTypeExperimentsClientTypeinterface to handle experiment clients.ExperimentsClientTypetoEnvironment.OptimizelyExperimentsClientis real implementation using Optimizely client.ApplicationModule.MockExperimentsClientTypeis test implementation.MockExperimentsClientTypeto baseEnvironmentinKSRobolectricTestCaseExperimentUtils.attributes.pledge_cta_copyexperimentOptimizeExperiment.Key.PLEDGE_CTA_COPYExperimentUtilsfor Optimizely attributes.ProjectViewUtils.pledgeActionButtonTextcan now also take in anOptimizelyExperiment.Variant.ExperimentUtils.ProjectViewUtilsandProjectViewModelTest👀 See
📋 QA
View the project page with native checkout enabled.
Story 📖
NT-599