[🔙] NT-843 Project Page Pledge Button Clicked event #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r clicks the Back this project button Added LakeEvent.PROJECT_PAGE_PLEDGE_BUTTON_CLICKED Tracking when a user clicks the Back this project button in ProjectViewModel Added tests in ProjectViewModelTest
justinswart
reviewed
Feb 10, 2020
| val refTagsAndProject = Observable.combineLatest<RefTag, RefTag, Project, RefTagsAndProject>(refTag, cookieRefTag, currentProject) | ||
| { refTagFromIntent, refTagFromCookie, project -> RefTagsAndProject(refTagFromIntent, refTagFromCookie, project) } | ||
| .filter { it.project.hasRewards() } | ||
| .take(1) |
There was a problem hiding this comment.
Do we need the take(1) with the takeWhen further down?
There was a problem hiding this comment.
I think so because currentProject emits again when the Project gets refreshed and we don't want to track this screen view again for those refreshes.
There was a problem hiding this comment.
Oh right - I guess in this case it wouldn't matter because the event doesn't track based on the screen refreshing but on the button press. Either way 🤷♂
justinswart
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adding
Project Page Pledge Button Clickedevent.🤔 Why
We have new Back a Project events.
🛠 How
LakeEvent.PROJECT_PAGE_PLEDGE_BUTTON_CLICKEDwith value"Project Page Pledge Button Clicked"Koala.trackProjectPagePledgeButtonClicked"Back this project"button inProjectViewModelProjectViewModelTest👀 See
No visual changes.
📋 QA
So many ways 2 QA:
ktkthe staging lakeLogcatin Android Studiodevproject in AmplitudeStory 📖
NT-843