8000 [ℹ️] NT-849 Adding id field to checkout model by eoji · Pull Request #735 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ℹ️] NT-849 Adding id field to checkout model #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

[ℹ️] NT-849 Adding id field to checkout model #735

merged 1 commit into from
Feb 13, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Feb 6, 2020 •
edited by jira bot
Loading

📲 What

Adding id field to Checkout model

🤔 Why

It will be used in the Back a project tracking events.

🛠 How

  • Added checkout.id field to CreateBacking and UpdateBacking mutations.
  • Added id field to Checkout model.
  • ApolloClientType.createBacking and updateBacking now return a Checkout.
  • Created CheckoutFactory to easily return mock Checkout objects for tests.
  • Updated PledgeFragmentViewModel and PledgeFragmentViewModelTest.

👀 See

Under the hood changes only.

📋 QA

Backing or updating a pledge should behave the same.

Story 📖

NT-849

@eoji
Added checkout.id field to CreateBacking and UpdateBacking mutations.
a7aee67 
Added id field to Checkout model.
ApolloClientType.createBacking and updateBacking now return a Checkout.
Created CheckoutFactory to easily return mock Checkout for tests.
Updated PledgeFragmentViewModel and PledgeFragmentViewModelTest.
@eoji eoji requested a review from justinswart February 6, 2020 19:34
@eoji eoji merged commit 81da325 into master Feb 13, 2020
@eoji eoji deleted the NT-849 branch February 13, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinswart justinswart justinswart approved these changes

Assignees
No one assigned
Labels
events 🛤
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @justinswart
0