8000 [🔍] NT-820 Search Page Viewed event and NT-821 Search Results Loaded event by eoji · Pull Request #722 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[🔍] NT-820 Search Page Viewed event and NT-821 Search Results Loaded event #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 22, 2020
Merged

[🔍] NT-820 Search Page Viewed event and NT-821 Search Results Loaded event #722

merged 3 commits into from
Jan 22, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Jan 21, 2020 •
edited by jira bot
Loading

📲 What

Adding Search Page Viewed event and Search Results Loaded event. I combined them to avoid conflicts!

🤔 Why

We have new Discovery events.

🛠 How

  • Added LakeEvent.SEARCH_PAGE_VIEWED const
  • Added LakeEvent.SEARCH_RESULTS_LOADED const
  • Calling lake.trackSearchPageViewed when user opens search screen
  • Calling lake.trackSearchResultsLoaded when search results are loaded
  • Updated Lake tests in SearchViewModelTest.testSearchProjectsWhenEnterSearchTerm and SearchViewModelTest.testSearchPagination

👀 See

No visual changes.

📋 QA

So many ways 2 QA:

  • ktk the staging lake
  • check the Logcat in Android Studio
  • Look at the dev project in Amplitude

Story 📖

NT-820 and NT-821

@eoji eoji requested a review from ifbarrera January 21, 2020 22:31
@eoji eoji merged commit 0909be4 into master Jan 22, 2020
@eoji eoji deleted the NT-820 branch January 22, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbarrera ifbarrera ifbarrera approved these changes

Assignees
No one assigned
Labels
events 🛤
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @ifbarrera
0