8000 [🕵🏾‍♀️] NT-818 Search Button Clicked event by eoji · Pull Request #721 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[🕵🏾‍♀️] NT-818 Search Button Clicked event #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2020
Merged

[🕵🏾‍♀️] NT-818 Search Button Clicked event #721

merged 1 commit into from
Jan 21, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Jan 17, 2020 •
edited by jira bot
Loading

📲 What

Adding Search Button Clicked event.

🤔 Why

We have new Discovery events.

🛠 How

  • Added LakeEvent.SEARCH_BUTTON_CLICKED const
  • Calling lake.trackSearchButtonClicked when user clicks the search menu icon
  • Added Lake tests in SearchViewModelTest.testSearchProjectsWhenEnterSearchTerm and SearchViewModelTest.testSearchPagination

👀 See

No visual changes.

📋 QA

So many ways 2 QA:

  • ktk the staging lake
  • check the Logcat in Android Studio
  • Look at the dev project in Amplitude

Story 📖

NT-818

@eoji eoji requested a review from ifbarrera January 17, 2020 21:25
@eoji eoji merged commit a6d99b9 into master Jan 21, 2020
@eoji eoji deleted the NT-818 branch January 21, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbarrera ifbarrera ifbarrera approved these changes

Assignees
No one assigned
Labels
events 🛤
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @ifbarrera
0