8000 [🎩] NT-825 Changing home sort to magic but for real this time by eoji · Pull Request #729 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[🎩] NT-825 Changing home sort to magic but for real this time #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from 8000
Jan 28, 2020
Merged

[🎩] NT-825 Changing home sort to magic but for real this time #729

merged 2 commits into from
Jan 28, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Jan 25, 2020 •
edited by jira bot
Loading

📲 What

Actually using magic sort as the default in Discovery

🤔 Why

In #240 I thought I was just making a copy change but I think we actually wanted to start sorting by "magic" 🙂

I'm considering this both a bug and a feature!

🛠 How

  • Renamed DiscoveryParams.Sort.HOME to DiscoveryParams.Sort.MAGIC
  • DiscoveryParams.Sort.toString returns "magic" for MAGIC
  • DiscoveryParams.Sort.fromString returns MAGIC for "magic"

👀 See

Screen Shot 2020-01-24 at 7 02 30 PM

📋 QA

Check your friendly LogCat.
ktk your user. discover_sort should now be magic

Story 📖

NT-825

@eoji eoji requested a review from Scollaco January 25, 2020 00:07
@eoji eoji added bug 🐛 and removed a11y ♿️ labels Jan 25, 2020
Scollaco
Scollaco approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor
@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GIF

@eoji eoji merged commit fa809bb into master Jan 28, 2020
@eoji eoji deleted the NT-825 branch January 28, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scollaco Scollaco Scollaco approved these changes

Assignees
No one assigned
Labels
bug 🐛 feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @Scollaco
0