8000 [🔒] NT-693 Adding client_id param to Lake requests by eoji · Pull Request #725 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[🔒] NT-693 Adding client_id param to Lake requests #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

[🔒] NT-693 Adding client_id param to Lake requests #725

merged 1 commit into from
Jan 23, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Jan 22, 2020 •
edited by jira bot
Loading

📲 What

Sending the client ID as a query param of requests to the Lake endpoint.

🤔 Why

SECURITY

🛠 How

  • Injected the clientId into LakeBackgroundService and passed it into LakeService.track that's annotated as a Query named "client_id"

👀 See

An extremely redacted request log:
Screen Shot 2020-01-22 at 4 39 35 PM

📋 QA

We don't currently test our network clients but I believe there is a ticket in the backlog.
Please check your friendly Logcat 🐱 on a debug build of the app for the Lake requests. The URL should contain a client_id query param.

Story 📖

NT-693

@eoji eoji requested a review from justinswart January 22, 2020 21:44
justinswart
justinswart approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor
@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too legit to ship. I mean lgtm! 🚢

@eoji eoji merged commit 58f8b72 into master Jan 23, 2020
@eoji eoji deleted the NT-693 branch January 23, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinswart justinswart justinswart approved these changes

Assignees
No one assigned
Labels
security 🔒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @justinswart
0