8000 [ℹ️] NT-813 Updating "partition-key" value in Data Lake events by eoji · Pull Request #724 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ℹ️] NT-813 Updating "partition-key" value in Data Lake events #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2020
Merged

[ℹ️] NT-813 Updating "partition-key" value in Data Lake events #724

merged 2 commits into from
Jan 23, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Jan 21, 2020 •
edited by jira bot
Loading

📲 What

Updating "partition-key" value in Data Lake events

🤔 Why

To help with session tracking.

🛠 How

  • When user is logged in the value of partition-key is user.id.
  • When user is logged out the value of partition-key is deviceDistinctId that returns a non-null String.

👀 See

No visuals~

📋 QA

tail your device's events in ktk

Story 📖

NT-813

@eoji eoji requested a review from amyfain January 21, 2020 23:34
@amyfain
Copy link
amyfain commented Jan 23, 2020

Looks good to me! 🎉

@eoji eoji merged commit 93e5f8a into master Jan 23, 2020
@eoji eoji deleted the NT-813 branch January 23, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyfain amyfain amyfain approved these changes

Assignees
No one assigned
Labels
events 🛤
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @amyfain
0