-
Notifications
You must be signed in to change notification settings - Fork 990
[🆕] NT-790 Additional Qualtrics properties #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated DiscoveryViewModelTest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit! Just had the two questions.
@@ -9,4 +9,8 @@ enum class QualtricsIntercept(private val prodId: String, private val testId: St | |||
else -> testId | |||
} | |||
} | |||
|
|||
fun impressionCountKey(packageName: String): String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression (lol) that we didn't need the impression count anymore if we're confident that Qualtrics won't prompt us once we've taken the survey? Anyway, suppose no real harm in keeping it unless you wanted to simplify your code without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This count is so we don't show users the prompt more than 3 times. Otherwise, we'd be hounding them until they took the survey.
@@ -5,6 +5,7 @@ private SharedPreferenceKey() {} | |||
|
|||
public static final String ACCESS_TOKEN = "access_token"; | |||
public static final String CONFIG = "config"; | |||
public static final String FIRST_SESSION = "first_session"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to persist this outside of Qualtrics? I figured since you're able to get the value stored in Qualtrics' properties you could check if there is already something there otherwise set it (for the first time user thing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learned the hard way that Qualtrics calls the initialization block more than once 😒 so that's why I'm moved it here
Tested and it seems to work woo woooo!! |
📲 What
Additional Qualtrics properties.
🤔 Why
😢
🛠 How
first_session
SharedPreference
that's passed through to Qualtrics asfirst_app_session
.{interceptID}_impression_count
property to Qualtrics.logged_in
anduser_uid
as embedded data in the survey url.👀 See
Nothing 2 c
📋 QA
@jamielynnroth this can't be verified until we update the intercept logic 🙏
Story 📖
NT-790