8000 [🆕] NT-790 Additional Qualtrics properties by eoji · Pull Request #715 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[🆕] NT-790 Additional Qualtrics properties #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2020
Merged

[🆕] NT-790 Additional Qualtrics properties #715

merged 3 commits into from
Jan 17, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Jan 16, 2020

📲 What

Additional Qualtrics properties.

🤔 Why

😢

🛠 How

  • Added first_session SharedPreference that's passed through to Qualtrics as first_app_session.
  • Added {interceptID}_impression_count property to Qualtrics.
  • Added logged_in and user_uid as embedded data in the survey url.
  • Added tests for survey url, impression count and first session.

👀 See

Nothing 2 c

📋 QA

@jamielynnroth this can't be verified until we update the intercept logic 🙏

Story 📖

NT-790

Copy link
Contributor
@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit! Just had the two questions.

@@ -9,4 +9,8 @@ enum class QualtricsIntercept(private val prodId: String, private val testId: St
else -> testId
}
}

fun impressionCountKey(packageName: String): String {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression (lol) that we didn't need the impression count anymore if we're confident that Qualtrics won't prompt us once we've taken the survey? Anyway, suppose no real harm in keeping it unless you wanted to simplify your code without it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This count is so we don't show users the prompt more than 3 times. Otherwise, we'd be hounding them until they took the survey.

@@ -5,6 +5,7 @@ private SharedPreferenceKey() {}

public static final String ACCESS_TOKEN = "access_token";
public static final String CONFIG = "config";
public static final String FIRST_SESSION = "first_session";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to persist this outside of Qualtrics? I figured since you're able to get the value stored in Qualtrics' properties you could check if there is already something there otherwise set it (for the first time user thing).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned the hard way that Qualtrics calls the initialization block more than once 😒 so that's why I'm moved it here

@eoji
Copy link
Contributor Author
eoji commented Jan 17, 2020

Tested and it seems to work woo woooo!!

@eoji eoji merged commit 9c02e6f into master Jan 17, 2020
@eoji eoji deleted the NT-790 branch January 17, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0