[🛁] Adding new tracking session properties #702
Conversation
Added ConfigUtils.currentVariants to return a JSONArray of current experiments. Added new session properties to TrackingClientType. Implemented new session property values in TrackingClient. Testzzzzz
| private @NonNull Map<String, Object> sessionProperties(final boolean userIsLoggedIn) { | ||
| final Map<String, Object> properties = new HashMap<String, Object>() { | ||
| { | ||
| put("android_uuid", androidUUID()); |
There was a problem hiding this comment.
On iOS we used to have ios_uuid but removed it since it's just the same value as device_distinct_id. You might be able to remove this prop as well.
| @@ -44,12 +44,32 @@ class LakeTest : KSRobolectricTestCase() { | |||
|
|
|||
| private fun assertDefaultProperties(user: User?) { | |||
There was a problem hiding this comment.
Should we consider renaming these tests to assertSessionProperties so that it's consistent with the sessionProperties function name?
There was a problem hiding this comment.
so these will include all properties including the session, context, and user groups so i don't think default is right but not sure session is true either. maybe just assertProperties?
There was a problem hiding this comment.
Ahh gotcha. I think maybe default makes sense then.
There was a problem hiding this comment.
so i renamed this method but left the test methods as assertDefaultProperties!
Removed android_uuid property and renamed method to deviceDistinctId
📲 What
Adding "Session Properties" tracking group.
🤔 Why
The first step of many for new tracking events.
🛠 How
abExperimentsproperty toConfigmodelConfigUtils.currentVariantsto return aJSONArrayof current experimentsTrackingClientTypeTrackingClient👀 See
Nothing 2 c here
📋 QA
All events sent to the Lake 💧 should have these properties. This is a WIP so I'm on hitting staging.
Story 📖
Part of [NT-654]