8000 [❔] NT-601 Qualtrics survey support by eoji · Pull Request #700 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[❔] NT-601 Qualtrics survey support #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 4, 2020
Merged

[❔] NT-601 Qualtrics survey support #700

merged 10 commits into from
Jan 4, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Jan 3, 2020 •
edited
Loading

📲 What

Adding support for Qualtrics survey.

🤔 Why

So we can survey users!

🛠 How

  • Added Qualtrics library.
  • Added QualtricsIntercept for survey intercept values.
    • QualtricsIntercept.id returns the testId unless the app package is the prod package.
  • Added QualtricsResult as a wrapper around TargetingResult so it's testable.
  • Added currentUser, and qualtricsPromptIsGone , and showQualtricsSurvey outputs to DiscoveryViewModel.
  • Added qualtricsConfirmsClicked , and qualtricsDismissClicked , and qualtricsResult inputs to DiscoveryViewModel.
  • The no service Snackbar won't appear over the Qualtrics prompt.

👀 See

Prompt for logged in user Opting in to survey Opting out of survey
device-2020-01-02-162611 2020-01-03 16_24_02 device-2020-01-03-183639 2020-01-03 18_39_01 device-2020-01-03-183707 2020-01-03 18_37_53

📋 QA

Log in on a device whose language is set to English.

Story 📖

[NT-601]

eoji added 3 commits December 17, 2019 12:15
@eoji
Wip supporting Qualtrics survey in Discovery
7a97be1
@eoji
Moved Qualtrics setup from KSApplication to DiscoveryActivity because…
5031e56 
… we need the most current user.

Created QualtricsResult as a wrapper for Qualtrics TargetingResult.
Added local strings for Qualtrics prompt.
Updated SmallButtonBase style.
Tests.
@eoji
removing unused secrets
fa3482e
@eoji eoji requested a review from justinswart January 3, 2020 22:10
justinswart
justinswart approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor
@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@eoji
PR feedback from Justin:
b4c4588 
Renamed QualtricsIntercepts to QualtricsIntercept.
Added id method to QualtricsIntercept to return the intercept ID based on the package name.
Tests for id method.
@eoji eoji changed the title [❔] NT-704 Qualtrics survey support [❔] NT-601 Qualtrics survey support Jan 3, 2020
@eoji eoji merged commit fde964e into master Jan 4, 2020
@eoji eoji deleted the NT-704 branch January 4, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinswart justinswart justinswart approved these changes

Assignees
No one assigned
Labels
feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @justinswart
0