8000 [🏴] NT-691 Go rewardless flag, take 2 by eoji · Pull Request #695 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[🏴] NT-691 Go rewardless flag, take 2 #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2019
Merged

[🏴] NT-691 Go rewardless flag, take 2 #695

merged 3 commits into from
Dec 9, 2019

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Dec 9, 2019

📲 What

Updating key for go rewardless flag.

🤔 Why

android_go_rewardless has been deprecated due to #693 in favor of android_go_rewardless_2 https://github.com/kickstarter/kickstarter/pull/18369

🛠 How

  • Updated value of FeatureKey.ANDROID_GO_REWARDLESS to android_go_rewardless_2.
  • Updated broken tests.

📋 QA

Go rewardless is only enabled on external builds that have android_go_rewardless_2 enabled.

Story 📖

NT-691

@eoji eoji added the bug 🐛 label Dec 9, 2019
Copy link
@setsun setsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward, LGTM! 👍

@eoji eoji merged commit 03772af into master Dec 9, 2019
@eoji eoji deleted the NT-691 branch December 9, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0